I saw this today:

Class>>#private_subclass: t instanceVariableNames: f classVariableNames: d 
poolDictionaries: s category: cat 

1) method name is not according to conventions (should be 
#privateSubclass:instanceVariableNames:classVariableNames: 
poolDictionaries:category:)
2) variable names are not good: t, f, d, s and cat do not means anything. 
3) if is private, needs to be in “private” protocol. 
4) more than “private” I think it’s function is “basic”… but that’s not a real 
problem :)

please, a fix?

Esteban

Reply via email to