On Thu, Jan 14, 2016 at 12:22 AM, David Allouche <[email protected]> wrote: > > By the way, how do you guys do code reviews for code integrated into the > core?
Its fairly informal. Once a Slice has been submitted to the Pharo5Inbox the associated Issue on Fogbugz is <Resolved> to "Fix review Needed" - people review it out and comment. Unfortunately with limited resources, sometime resolved issues can languish if reviewer don't feel its within their expertise, and often it falls the to small group of the core-devs from Inria. As Pharo grows more popular we may need some improved processes to reduce load on core-devs. I'd be interested in what you've seen work in other environments. Have you seen these... http://pharo.org/contribute-propose-fix https://pharo.fogbugz.com/?W68 cheers -ben
