On the meantime at least change the handler to ignore the halts.

...  on: Exception - Halt

Should do the trick
On Mar 31, 2016 06:57, "Esteban Lorenzano" <[email protected]> wrote:

>
> On 30 Mar 2016, at 19:54, Aliaksei Syrel <[email protected]> wrote:
>
> Do anyone really use GLM-Morphic-Brick?
>
> Because it is there just for spotter and will be deleted ASAP.
>
> We know that it is bad. Normal fix requires too many changes...
>
> but catching Exception is bad because it will catch all, even Warnings and
> Halts.
> It would be less bad if it catches Error (not Exception). Still bad, but
> less bad :)
>
> Esteban
>
> On Mar 30, 2016 1:34 PM, "Nicolai Hess" <[email protected]> wrote:
>
>> Please don't do this:
>>
>> updateHeight
>>     "no need to care about height, when it's logic is not customized"
>>     self layout isHeightCustom ifFalse: [ ^ self ].
>>     [ self bounds: (self brickBounds withHeight: self customHeight) ]
>>         on: Exception
>>         do: [ "just skip and do nothing" ]
>>
>> This makes debugging GLM/Brick ui/layout code with "self haltOnce"
>> impossible.
>> see
>> GLMBrickGeometryTrait>>#updateHeight
>> GLMBrickGeometryTrait>>#updateWidth
>>
>> And if you log out the raised exception, you see some calls to
>> not initialized fonts and a ZeroDevide and some more errors.
>> The above catch, catches and hides wrong / to late initialized objects.
>>
>
>

Reply via email to