Also regarding `#smallFindIcon asIcon`, there are many places where we can 
enter icons (e.g. Spec), so once we make a choice for Settings we should modify 
it there too.

Peter

On Wed, Oct 12, 2016 at 03:01:26PM +0200, Peter Uhnak wrote:
> On Wed, Oct 12, 2016 at 02:28:44PM +0200, Denis Kudriashov wrote:
> > Hi Stef.
> > 
> > It is really good idea. And it makes me think why we ask users for real
> > icon Form and not just name?
> 
> Because ThemeIcons may not be the only place from which you draw icons, and 
> because programming with strings doesn't scale.
> 
> In any case, assuming we can easily customize the icon retrieval (with the 
> default being Smalltalk ui icons), then I have no problems with this.
> 
> Btw, there was a push to use also `#smallFindIcon asIcon`, I am not sure if 
> this is possible in Pharo 6. (this is nice and short for standard icons, but 
> cannot be customized, which is sometimes problem).
> 
> Pharo
> 
> > 
> > We could say any component which shows icons should be created with
> > concrete ThemeIcons ("Smalltalk ui icons" by default) to retrieve actual
> > form by name. And users should always specify icon names instead of forms.
> > 
> > What you think?
> 
> 
> 
> > 
> > 
> > 2016-10-12 13:25 GMT+02:00 stepharo <steph...@free.fr>:
> > 
> > > Hi glamourers and other
> > >
> > > Hi
> > >
> > > I'm currently enhancing the API of Settings to propose to the users to
> > > pass not an icon but an icon named so that all the clients are not force 
> > > to
> > > use. See below.
> > >
> > > Now it would be great if Glamour could do the same.
> > >
> > > Doru and Andrei?
> > >
> > >
> > > menuOn: aBuilder
> > >     "Specify the menu used when writing text."
> > >     <contextMenu>
> > >     <RubLineNumberMenu>
> > >     (aBuilder item: #'Find...' translated)
> > >         keyText: 'f';
> > >         selector: #find;
> > >         icon: (Smalltalk ui icons iconNamed: #smallFindIcon)
> > >
> > > ====>
> > >
> > > menuOn: aBuilder
> > >     "Specify the menu used when writing text."
> > >     <contextMenu>
> > >     <RubLineNumberMenu>
> > >     (aBuilder item: #'Find...' translated)
> > >         keyText: 'f';
> > >         selector: #find;
> > >         iconNamed: #smallFindIcon
> > >
> > >
> > > Stef
> > >
> > >
> > >
> > >

Reply via email to