Ah, now I understand. So there are already inline critiques support where I highlight text and provide information on the side bar. Doing the smart suggestions won’t be super hard, because I have some critiques that know the exact node that violates the rule and can have a replacement node. So yes, the would be a nice extension.
Uko > On 2 Apr 2017, at 16:50, Guillermo Polito <[email protected]> wrote: > > > > On Sat, Apr 1, 2017 at 9:42 PM, Yuriy Tymchuk <[email protected] > <mailto:[email protected]>> wrote: > Hey Guille! > > Now I’m interested :) Can you explain a bit more? Because there are already > some autofix suggestions. What exactly do you suggest? Is selected ast node > something a rule detects or is it selected by a user? > > What I mean by suggestions is the "smart suggestions" tool. The one that > gives you a contextual menu given the selected AST in the code. Smart > suggestions already allow you to show some actions given an AST node. It is > used to show so far some meta-links (breakpoints, watchers), refactorings > (targetting the specified node), and code navigation (senders, implementors). > > It would be nice because from the text editor you can access the suggestions > with (ctrl | cmd) + t. I did not see an already existing integration of > renraku with this, but maybe there is. > > Cheers. > Uko > >> On 1 Apr 2017, at 15:07, Guillermo Polito <[email protected] >> <mailto:[email protected]>> wrote: >> >> Yes! Actually offering fixes and transformations from renraku based on the >> selected ast node could be really cool! >> >> On Fri, Mar 31, 2017 at 7:21 PM, Stephane Ducasse <[email protected] >> <mailto:[email protected]>> wrote: >> This is a super topic. >> What would be good is to check the smart suggestions because they need more >> love. >> >> Stef >> >> On Fri, Mar 31, 2017 at 3:14 PM, Myroslava Romaniuk <[email protected] >> <mailto:[email protected]>> wrote: >> Hello, >> >> I'm Myroslava and I'm studying Computer Science at the Ukrainian Catholic >> University in Lviv. As part of my Google Summer of Code project I'm going to >> work on the quality of code in Pharo. This >> <https://docs.google.com/document/d/1cX7VJ2QZejq_Cu6Ur28UCiUwzSD-Bu8GgSDqECiu1fs/edit?usp=sharing> >> is my proposal draft, and I would really appreciate some feedback, >> comments, suggestions and so on. >> >> Thanks! >> >> > >
