Hi Subbu, On Tue, Apr 18, 2017 at 09:04:00PM +0530, K K Subbu wrote: > Hi, > > I stumbled on an error in WriteStream>>ensureEndsWith: method. The error > caused extra blank lines in logs. > > Attached small changeset fixes it. It also adds a test to catch such errors > in the future. With this fix, > > ./pharo generator.image PharoVMSpur32Builder buildUnix32 > > gives a compact output without extra blank lines. > > To which box in which repo should I save this cs for mainlining it? > > Regards .. Subbu
This appears to be changing the meaning of #ensureEndsWith:. The previous meaning was that it always ends with the supplied object. You've modified it to mean that an empty collection doesn't have the object appended. Is that really what the method is supposed to mean? The comment matched the previous implementation, with your change, it doesn't. If the change does go ahead, the comment should be updated to reflect the changed definition. I'm also wondering why you've changed the test to hard-code a string stream? Cheers, Alistair
