Hi Stéphane, > On Jun 15, 2017, at 7:44 AM, Esteban Lorenzano <[email protected]> wrote: > > I’m sorry but I will need to intervine here :) > While it may look complicated /now/, it is because we are still fixing Pharo7 > to work, who has a problem right now because since is bootstrapped it does > not keeps any version info… then is complicated to calculate the diffs. But > we are going to fix this. > > Now, this is how the process will work once released: > > 0. You will have to have a fork of pharo (this is like that and is “zero” > because you doit once) > 1. You will clone pharo, using iceberg. This can be achieved two ways > a) by cloning if is first time. > b) by adding it if you already have this clone. Most people will end > using this option. > 2. work on fix/change > 3. commit/push to your repo > 4. do a Pull Request once finished. > > done. As you can see, this is very easy… Pavel showed an overcomplicated > process that is just a workaround until we fix the problem I mentioned :)
From the website Create a slice (group of packages): Open the Monticello Browser. Open the Slice Maker by clicking the "Slice" button. In Slice Maker enter the Fogbugz issue number and "grab" the issue summary. Select the dirty packages relevant to your bug fix. Dirty packages are prefixed by a start and are sorted to the top of the list of packages. Verify your changes (click on changes button) Select the Pharo60 repository Select your slice Press changes in the Monticello Browser and verify that your changes are the correct one. Publish the slice to Pharo50Inbox: Select the whole slice (not it's individual packages). Select the SmalltalkHub Pharo Inbox repository. Press the "Save" button to commit your slice to the inbox repository Verify that your fix loads: take a fresh image and load the slice you published. Update the bug entry to mention that you submitted a slice in the inbox. In Fogzbugz, click on "Resolve" to Change the state of the issue to "Resolved: Fix Review Needed" and ensure that the milestone is set to the next release of Pharo. Now you can feel good! Too many steps. Why is there still no integration with FogBugz? Then there's the dubiousdescign decision of making a slice a selection of dirty packages instead of a selection of changes (what if I work on two things at once and they touch the same package? => two Images). How old is the slice process and there's no integration with fogbugz, shifting between tools. When is iceberg going to be better integrated than the slice process? > > >> On 15 Jun 2017, at 15:40, Guillermo Polito <[email protected]> wrote: >> >> Thanks pavel, I'll copy paste it in the README :) > > I will not copy and paste all that in the README. It will not remain... > > cheers, > Esteban > > >> >>> On Thu, Jun 15, 2017 at 10:43 AM, Rajula Vineet <[email protected]> >>> wrote: >>> @abergel I was looking for some basic guidelines for example: creating a new >>> branch with the issue name, having the issue number and name while >>> submitting a PR. Something like this. >>> >>> @Subbu I have forked it, but I haven`t made a new branch I will do it. >>> Thanks for the tips. >>> >>> @Pavel Thank you very much. This is what I was looking out for. >>> >>> Rajula >>> >>> >>> >>> >>> >>> >>> -- >>> View this message in context: >>> http://forum.world.st/Doing-a-pull-request-tp4951443p4951485.html >>> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >>> >> >> >> >> -- >> >> Guille Polito >> >> Research Engineer >> French National Center for Scientific Research - http://www.cnrs.fr >> >> >> Web: http://guillep.github.io >> Phone: +33 06 52 70 66 13 >
