but this is because we still need to stabilise the CI: what happens now is that we know some tests are failing randomly then we do not trust the CI to tell us everything is ok. Then we accept PRs in red state. Of course, this will fail eventually, and that’s what we are seeing.
Most important thing, IMO is to fix the CI: those tests that fails randomly (I think most of them are networking problems) needs to be fixed or removed. You would say “you cannot remove a test of X” but in fact, a test that fails because of non controllable reasons is a bad test. Then, we need to have a “no red integration” policy. This will fix this problems, but of course, we need to work to make this happen ;) Esteban > On 18 Dec 2017, at 09:21, Pavel Krivanek <[email protected]> wrote: > > The same for https://github.com/pharo-project/pharo/pull/514 > <https://github.com/pharo-project/pharo/pull/514> > > :-( > > 2017-12-18 9:12 GMT+01:00 Pavel Krivanek <[email protected] > <mailto:[email protected]>>: > it was a bad idea to integrate PR 606 [1] about the world menu tooltips > before it was green. Now we have failing tests in the development branch and > validations of new pull requests will fail immediately. > > Btw. I do not think this test should be in the ReleaseTest because these > tests should be valid for the minimal image too. > > [1] https://github.com/pharo-project/pharo/pull/606 > <https://github.com/pharo-project/pharo/pull/606> > > -- Pavel > >
