Hi Guille, On 19 March 2018 at 13:59, Guillermo Polito <[email protected]> wrote: > Hi! > > On Mon, Mar 19, 2018 at 9:17 AM, Alistair Grant <[email protected]> > wrote: > > [SNIP] >> >> >> >> https://pharo.fogbugz.com/f/cases/21615/Separate-bootstrap-process-in-to-distinct-stages >> >> https://github.com/pharo-project/pharo/pull/1127 >> >> This does the first step of breaking the bootstrap process in to >> distinct phases and moving all the downloads to the start (e.g. >> allowing a test VM to be substituted for the build stage). > > > Nice! thanks! > >> >> >> Once this is integrated I can submit a PR that modifies Jenkinsfile to >> use the new shell scripts, removing code duplication. > > > Question: Why not in this same PR?
Because I'm not at all familiar with Jenkins, so am a bit nervous about changing it. Smaller changes will be easier to work on if something goes wrong. :-) Cheers, Alistair >> On 16 March 2018 at 14:38, [email protected] <[email protected]> wrote: >> > Hi, >> > sorry my mistake when updating the scripts. As the bootstrap.sh is >> > not >> > executed during the Jenkins process it has not been validated (locally >> > I'm >> > not using that script, because is trying to download each time the VM >> > and >> > the bootstraping process image) >> >> There are also scripts to snapshot and restore the bootstrap state, >> avoiding the need to do the multiple downloads. >> >> Just to be clear again: This is intended to complement and help with >> the goal of moving the bootstrap process to pure Pharo code. Each of >> the shell scripts can eventually be replaced by a call to the >> equivalent Pharo code. >> > > :) > >> >> >> Thanks! >> Alistair >> > > > > -- > > > > Guille Polito > > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > CRIStAL - UMR 9189 > > French National Center for Scientific Research - http://www.cnrs.fr > > > Web: http://guillep.github.io > > Phone: +33 06 52 70 66 13
