Tested manually. OK from this Dark Theme user, Thx !

> On 9 May 2018, at 08:59, Torsten Bergmann <[email protected]> wrote:
> 
> Peter wrote:
>> Finally, consider the following test: In a dark room, only monitor with 
>> pharo and dark theme is producing light. Now a large popup with yellow 
>> background appears... did your eyes squint? can you suddenly see >the other 
>> side of the room? :)
> 
> Instead of hypothetical tests I tend to code in a light room and rather use 
> the practical approach of
> fixing an issue when it appears or when I get blamed for it :P
> 
> All details and a proposed solution are summarized in new issue: 
> https://pharo.fogbugz.com/f/cases/21856/
> which 
> - will not hardcode the balloon background color (as it was before the 
> introduction of #21809)
>   by using a lighter version of the darkBaseColor for balloonBackgroundColor 
> in DarkTheme
> - nonetheless exactly restores the actual color values of the dark theme as 
> before the introduction of issue #21809
> - still allows to define a tooltips text color on the graphics theme as it 
> was the goal in #21809
> 
> Also a new PR is awaiting a review: 
> https://github.com/pharo-project/pharo/pull/1320
> 
> Thx
> T.
> 


Reply via email to