https://pharo.manuscript.com/f/cases/22035/Delete-PNGReadWriter-class-createAFormFrom
> On 31 May 2018, at 19:43, Sven Van Caekenberghe <[email protected]> wrote: > > Great, so you agree that #createAFormFrom: is a candidate for removal ? > >> On 31 May 2018, at 19:01, Hilaire <[email protected]> wrote: >> >> This is what I did, But I hope this problem will not hit somewhere else. >> >> >> Le 31/05/2018 à 18:06, Sven Van Caekenberghe a écrit : >>> That is because that particular method (with no users in the image) uses a >>> deprecated class, change it to the simpler >>> >>> createAFormFrom: data >>> | error f | >>> error := ''. >>> f := [ self formFromStream: data readStream ] ifError: >>> [ :a :b | >>> error := a printString , ' ' , b printString. >>> (StringMorph contents: error) >>> color: Color red; >>> imageForm ]. >>> ^ { f. error } >>> >>> but honestly, why this method and why not directly do >>> >>> self formFromStream: data readStream >>> >>> swallowing errors is so/so, IMHO. Also, the return value is really unusual. >>> You just want the Form, right. It is not the responsibility of a system >>> class to do UI for you, I think. >> >> -- >> Dr. Geo >> http://drgeo.eu >> >> >> >
