Hi Henrik,
> On 16 Oct 2018, at 15:16, Henrik Sperre Johansen
> <[email protected]> wrote:
>
> Sounds great!
>
> As for feedback, I've ported a slightly old version to VAST semi-manually
> (which was a minimal amount of work, thank you!), from before Traits were in
> use.
Thx for working on the code base and porting to VAST.
> Most fit neatly into a compatibility layer, only a few small things in
> STON-Core stood out as things I ended up fixing inline, which could be
> suitable for changing in the Pharo canonical version:
>
> STONReader >> #parseNamedInstVarsFor:
> instVarNamed:put: takes a string as arg in VA (at least in VA, strings and
> symbols are not interchangeable), so had to add an asString. Pharo code
> would continue to work with this in base.
Hmm, yes, I will have a look to see how we solved this for NeoJSON with
Mariano.
> In STONReaderError >> #messageText, format: isn't very portable, and can be
> somewhat cumbersome to port.
> I ended up replacing it with expandMacrosWithArguments:, which (afaik) works
> in multiple dialects (VA, Pharo, and VW,that I know of);
> 'At character <1s>: <2s>' expandMacrosWithArguments: #('12' 'Test')
OK, I'll note this and have a look later on.
Sven
> Cheers,
> Henry
>
>
>
>
>
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
>
