Hi, > On 1 Nov 2018, at 17:59, Alistair Grant <[email protected]> wrote: > > Hi Sven, > > On Wed, 31 Oct 2018 at 16:44, Sven Van Caekenberghe <[email protected]> wrote: >> >> Hi, >> >> Current FileStream holds (in the protocol 'file reader services') some >> constants regarding source/changes file suffixes. >> >> Where should we move these to (as FileStream is deprecated) ? >> >> There is a class SourceFile, there is PharoFilesOpener, neither seems to fit >> that well. >> >> Suggestions ? > > Can you clarify why you think SourcFile is not a good candidate?
The name is of course good, but the functionality is not really related. If others think this is a good place, then it is OK for me too. > #changesFileSuffixes, #isChangesFileSuffix:, #isSourceFileSuffix:, > #sourceFileSuffixes all relate to specifying source files, so could > possibly go to SourceFile. OK > #fileIn: should be deprecated. FileReference>>fileIn provides the same > functionality. Yes > #removeLineFeeds: seems to be unused. Deprecate as well? Yes > Cheers, > Alistair
