> On 23 Aug 2019, at 12:43, Marcus Denker <marcus.den...@inria.fr> wrote:
> 
> 
> 
>> On 23 Aug 2019, at 12:13, Denis Kudriashov <dionisi...@gmail.com 
>> <mailto:dionisi...@gmail.com>> wrote:
>> 
>> Hi
>> 
>> пт, 23 авг. 2019 г., 11:06 Marcus Denker <marcus.den...@inria.fr 
>> <mailto:marcus.den...@inria.fr>>:
>> 
>> 
>> > On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferli...@gmail.com 
>> > <mailto:cyril.ferli...@gmail.com>> wrote:
>> > 
>> > Hi,
>> > 
>> > Since yesterday I get a lot of bugs when I try to edit class
>> > definitions while having the slot template in class definition
>> > enabled. (See comment:
>> > https://github.com/pharo-project/pharo/pull/4391 
>> > <https://github.com/pharo-project/pharo/pull/4391>)
>> > This make it a little hard to develop :(
>> > 
>> > Is there an easy fix? Else maybe we should revert the change until we
>> > have the fix?
>> > 
>> 
>> I have a fix, I will commit when the internet connection is good enough
>> 
>> That's good.
> 
> https://github.com/pharo-project/pharo/pull/4409 
> <https://github.com/pharo-project/pharo/pull/4409>
> 
> 
>> 
>> I guess it was a class parser bug? I only tested browser with classic 
>> definition.
> 
> yes, even with this fix I need to do some (larger) change to support Slots 
> with parameters, e.g.
> 
>       {#lazy => LazySlot default: 5 .
>          #computed => ComputedSlot with: [:object | object 
> calculateSomething] }
> 
> 

I updated the fix: now it should work, there will be just no menu shown for 
these kinds of slots for now
(to be fixed in a second step, we should add tests, too)

        Marcus

Reply via email to