> On 8 Sep 2019, at 14:12, Hilaire <[email protected]> wrote:
>
> Hi,
>
> Reading the tutorial
> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo
>
> * At
>
> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo#solving-the-detached-working-copy
>
> I don't have Detached Working Copy but uncommited changes.
>
> * When I create a new branch from issue, should I use origin or pharo
> repo ? When I fill in the issue number with origin I have an
> INVALID-ISSUE title
you should use the pharo one because this is the one that contains the bug
entries
> With pharo-project repo, it fetches the title correctly though. So I
> take this one.
Yes this is correct.
>
>
> *
> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo#step-4-issue-a-pull-request
>
> To push the change, (I need to pull to push?). A question is raised
> "pharo has ongoing modifications (uncommit changes) Indeed I did not
> commit. It was not mentioned in tutorial. Was it forgotten or do I miss
> something? So I commit it.
When you push it will check and will pull automatically.
> Ah, now when I create the pull request, it complains the branch does not
> exist and I should commit before and push the changes.
You should
commit to your fork
push to your fork
and do a PR (because the PR is from a branch of your repo to a branch
to the pharo repo)
> Likely I should not have commited in the first place.
No committing is always good.
>
> What should I do now?
What I do in general is
download latest image
repair
in detached copy I do create new branch (I call bottomx…)
repair
then I do create branch from issue
commit
commit
push
then PR
If you need help we can organise a screen sharing session.
>
> Hilaire
>
> --
> Dr. Geo
> http://drgeo.eu
>
>
>
