> On 11 Nov 2019, at 15:04, ducasse <steph...@netcourrier.com> wrote: > > marcus I read your fix and I do not understand why the previous way was a > problem. > What was your hypothesis? >
I think the problem is that it forces recompiling methods while already loading code, which leads to some strange effect.. that I think the MethodChanged that monticello does at the end references the old method, but that got recompiled in the meantime. Something like that. > Stef > >> On 11 Nov 2019, at 14:46, Marcus Denker <marcus.den...@inria.fr >> <mailto:marcus.den...@inria.fr>> wrote: >> >> >>>>> >>>>> Hi, >>>>> >>>>> During our work we encountered two issues we think should be considered >>>>> critical. >>>>> >>>>> The first is that the garbage collector is unreliable on larger images: >>>>> https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/391 >>>>> <https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/391> >>>>> We stumble on this when we manipulate larger pieces of data quite >>>>> consistently in plain Pharo (7 or 8). We lack the knowledge of how to >>>>> approach it, but we would happily pair and try to reproduce it with >>>>> someone. >>>>> >>>>> The second one is that the sources contain wrong pointers, and this makes >>>>> it hard to work with TFFI: >>>>> https://github.com/pharo-project/pharo/issues/4967 >>>>> <https://github.com/pharo-project/pharo/issues/4967> >>>>> This is already marked as important. We spent quite some time >>>>> investigating this, especially in the context of TFFI, and we would be >>>>> happy to pair to work through it. >>>>> >> >> I think my PR fixes it… the PR is green and the downloaded artefact seems to >> not show any problematic methods anymore: >> >> https://github.com/pharo-project/pharo/pull/5120 >> <https://github.com/pharo-project/pharo/pull/5120> >> >> >> >> Marcus >
