Hi Alexandre, thanks for this review. On Monday 16 June 2008 09:34:26 Alexandre Bergel wrote: > > http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000323.html > >>> [Pharo-project] MVC removal step2 investigations ... > Few questions: > - Inspector>>openOn: anObject withEvalPane: withEval withLabel: label > valueViewClass: valueViewClass seems to be called by FormInspectView > class>>openOn: aFormDictionary withLabel: aLabel > Don't you think that removing this method might be a problem? FormInspectView class is removed > - Why have you removed PasteUpMorph>>open ? Here is it's code: PasteUpMorph>>open "Open a view on this WorldMorph." MorphWorldView openOn: self. MorphWorldView is a subclass of View (MVC) which is removed. So PasteUpMorph>>open makes sense only in MVC context. > > Je n'ai vu aucun problème après avoir chargé le removal. > I favour an inclusion. I would only insist on the following point: One big change concerns the Controller hierarchy which was Controller #('model' 'view' 'sensor' 'lastActivityTime') MouseMenuController #('redButtonMenu' 'redButtonMessages') ScrollController #('scrollBar' 'marker' 'savedArea' 'menuBar' 'savedMenuBarArea') ParagraphEditor #('paragraph' 'startBlock' 'stopBlock' 'beginTypeInBlock' ' and which becomes: Controller #('model' 'sensor' 'lastActivityTime') ParagraphEditor #('paragraph' 'startBlock' 'stopBlock' 'beginTypeInBlock' 'emphasisHere' 'initialText' 'selectionShowing' 'otherInterval' 'lastParentLocation')
as you can see, MouseMenuController and ScrollController are removed and ParagraphEditor is now a direct subclass of Controller. Controller is now more simple because of 'view' instance variable removeal. I think that 'lastActivityTime' can be removed too and I've also noticed more cleaning possibilities implied by this changeset. Especially in class ScreenController which holds a lot of menu methods which are not used anymore (world menu equivalent methods but in the context of MVC). I will provide a changeset or a slice later. alain > > Cheers, > Alexandre > _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
