Hi lukas
I am horrified with all these colored icons on methods. That's worse
than in the old browser with the button that had 8 different colors
depending on the state of the method.
Uh?
Lukas I think that david is spending a lot of time on improving the
browser
so I would suggest you to be less aggressive and more bringing
suggestions.
Having good icons is important. I go much faster with icons than
without.
May be we should build a study on that and evaluate what is good.
- I don't want to see part of the "contents" of a method as an icon.
The super-icon is useless, it only hides valuable information (for
example that there is a sub-implementation). If I want to know if a
method calls super (and when) I need to look at the method anyway.
No I'm sorry but I disagree.
Knowing that there is a supercall is as important as knowing that the
method
is specialized.
Look at LimitedWriteStream you get instantanly the fact that the three
methods are doing a super send!
and this is really important to know.
- The same is for abstract method icon. When browsing the
protocol/interface I don't need to know that. I am more interested if
any of the subclasses override it.
No this is your point of view on that. But knowing that a method is
abstract
is useful too
So may be we should have combination of the information.
=>
this method is abstract and there are specialisation:
normally this should be quite rare that the method is not
overridden.
one icon for method doing a super-send and been specialized
we can have the shape for one dimension and the color for the other
one.
I browsed contents on WriteStream and I would like to know
whether there is a supercall.
For me this is much more important than to know that there is a
specialization
because as you say I can know if I click on the subclasses.
But to show you that when I use your argument I'm also wrong :)
if you look at RWBinaryOrTextStream with the package view and not the
inheritance
hiearchy then you could say ok I just have to clik on the subclasses
but you do know that there
is one. So knowing that padToEndWith: is actually define in a subclass
is a good information.
As the supercall and abstract is.
So conclusion having both information would be good.
May be we should get two icons because screen space is cheap.
- The same for extension methods. I see that, because it is in a
different protocol and because its name is in italic (the same as with
the extension classes). I don't need yet another icon.
It depends on which browser you are. Reinforcing the information is
often good.
The only valuable thing for me as a developer is to know if there is a
super/sub implementation of a method. And maybe if there are halts
inside.
Sorry but knowing that there are self flag and halt is extremely
valuable.
The rest I can find out with one click or less, if necessary.
But we do not want that click.
I do not know to click on all the method of my class to see if they
all do a supercall.
This would greatly improve the interface. The browser starts to be
really messy.
Furthermore I would like to define my own icons for classes, for
example Seaside component should have its own icon. So instead of
hardcoding this into OB itself why not asking the class for an icon,
as this is done in VW for example.
Yes this is a good suggestion!
I would like to know the method performing exception handling.
David I found that
add: newObject
self shouldNotImplement
is displayed in cyan as abstract but this is not the same.
Stef
Cheers,
Lukas
--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
