Indeed, the changeset is totally bogus... must have got tripped up in the change sorter (mostly use MC so I don't use the sorters very often)!

Found the correct one now... attached.

Regards, Gary.

----- Original Message ----- From: "David Röthlisberger" <[email protected]>
To: <[email protected]>
Sent: Thursday, January 29, 2009 1:43 PM
Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution


Hi Gary,

Not heard from David since I emailed on 30th Dec about getting OB to be
less hardcoded about direct use of model colours, along with having
buttons changed to PluggableButtonMorphPlus (to use enablement rather
than on/off state to indicate enablement)...

yep, sorry, I was busy with other stuff.

But still I'm not sure about the question I sent to you beginning of this year as an
answer to your mail from the 30th of December:

"Concerning the first issue about #adoptPaneColor:
In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we
commit it? I don't think it should be part of OB."

To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine
that this patch fixes the problem.
I therefore think we should fix this color problem differently.
If you know another solution, please let me know, otherwise I will dive into it.

I will in the meantime look at the PluggableButtonMorphPlus issue.

Cheers,
David


Regards, Gary.

    ----- Original Message -----
    *From:* Rob Rothwell <mailto:[email protected]>
    *To:* Pharo Development <mailto:[email protected]>
    *Sent:* Tuesday, January 27, 2009 11:32 PM
    *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick
    Solution

    I know OB has some issues with the Polymorph themes such that you
    are always left with the standard browser window color border in the
    window panes of an OB Browser.

    At any rate, a simple "Preferences setPreference:
    #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)"
    seems to set it to a decent color for the Watery2 or Watery theme,
    but I was wondering if there is a better place to set something like
    this more...dynamically...when different themes are chosen.

    Thanks,

    Rob

    ------------------------------------------------------------------------

    _______________________________________________
    Pharo-project mailing list
    [email protected]
    http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


------------------------------------------------------------------------

_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Attachment: OBMod.1.cs
Description: Binary data

_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to