I went through your change. Very small change, lean, and well tested. Cheers, Alexandre
On 30 Jan 2009, at 08:47, Lukas Renggli wrote: > I committed a patch that adds literal byte arrays to Pharo, with the > same syntax as most other Smalltalk do (VW, VASt, GST). > > http://code.google.com/p/pharo/issues/detail?id=468 > > I would appreciate if somebody could review the change, as it would be > very useful for Seaside and solves reoccurring headaches. In my image > I have almost 50 places where even the Pharo base code could profit > from this extension, these places can be identified using the search > expression: > > `#literal asByteArray > > I can provide a refactoring at a later point, if desired. > > The change is simple and loads through Monticello, even if this is > modifying the scanner on the fly. > > Cheers, > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
