2009/4/22 Michael Rueger <[email protected]>:
> Hi all,
>
> in the Pharo inbox there is now
> Kernel-michael_rueger.renggli.304
>
> integrated John's Mac menu fixes
> fixed problems with shift cursor
> fixed and cleaned up input sensor/fetcher installation
>
> After loading the package you need to execute
> InputEventSensor installPollingEventSensorFramework
>
>
> Hopefully this will fix all the recent issues around input events.
>
> Thanks to all contributors and testers!
>

Michael, have you adressed the potential problems , which i mentioned:

- protect a handlers collection from concurrent access
- installing a new event fetcher should preserve the list of handlers,
by taking them from the currently installed one
- ?maybe? , when installing new event fetcher, use  #become: to make
sure anything which were pointed to old fetcher will now point to a
new one.

I don't have an updated version, but i think the InputEventHandler
doesn't needs to hold a reference to the fetcher i.e. because it
creates a reference cycle (fetcher has a handler in its handlers
collection, and handler has a fetcher in its ivar).
I'd recomment to rewrite register/unregister procedure to just:

InputEventFetcher default [un]registerHandler: self

and make sure , fetcher cares about possible handler duplicates
(registering an already registered handler should be an no-op).

> Michael
>
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



-- 
Best regards,
Igor Stasenko AKA sig.

_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to