+1

Stef

On Oct 11, 2009, at 3:26 PM, Lukas Renggli wrote:

> PrimitiveNode and #primitiveNode is referenced by the AST package.
> Probably used by the NewCompiler.
>
> I suggest to get rid of it. If the NewCompiler uses it, it should be
> packaged with the NewCompiler. #primtiveNode and PrimtiveNode was
> implemented/referenced by the AST package as well, I killed it too
> because it is not used by the Refactoring Engine.
>
> Lukas
>
> 2009/10/11 Adrian Lienhard <[email protected]>:
>> CompiledMethod>>primitiveNode refers to PrimitiveNode in Pharo-core.
>> This method has no senders. Can it be removed?
>>
>> Adrian
>>
>>
>> CompiledMethod>>primitiveNode
>>
>>        | primNode n |
>>        primNode := PrimitiveNode new num: (n := self primitive).
>>        (n = 117 or: [n = 120]) ifTrue: [
>>                primNode spec: (self literalAt: 1)].
>>        ^ primNode
>>
>>
>> On Oct 6, 2009, at 17:53 , Lukas Renggli wrote:
>>
>>> I think I fixed the issue in the latest AST package. Even
>>> PrimitiveNode is referenced, it is not really needed anywhere.
>>>
>>> Lukas
>>>
>>> On Tuesday, October 6, 2009, Damien Cassou <[email protected]>
>>> wrote:
>>>> On Tue, Oct 6, 2009 at 8:39 AM, Marcus Denker <[email protected]>  
>>>> wrote:
>>>>> Damien, can you add this to the AST package used in the DEV image?
>>>>
>>>> Done. Thank you
>>>>
>>>> --
>>>> Damien Cassou
>>>> http://damiencassou.seasidehosting.st
>>>>
>>>> "Lambdas are relegated to relative obscurity until Java makes them
>>>> popular by not having them." James Iry
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [email protected]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>>
>>>
>>> --
>>> Lukas Renggli
>>> http://www.lukas-renggli.ch
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [email protected]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [email protected]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
>
> -- 
> Lukas Renggli
> http://www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to