On Nov 8, 2009, at 10:21 AM, Lukas Renggli wrote:

> Something slightly unrelated:
>
> Already last week I fixed all but one of the broken refactoring tests.
> AFAIK, these tests never worked in the Squeak or Pharo port of the
> refactoring engine. Last time I check we had 60 plus broken tests. Now
> the situation is better:
>
>   334 run, 333 passes, 0 expected failures, 1 failures, 0 errors, 0
> unexpected passes

Excellent
Because they were refactoring I could not understand their effect

> Furthermore, I spend an hour to fix all the OmniBrowser tests. Some of
> them used to be broken in Pharo for a long time:
>
>   546 run, 546 passes, 0 expected failures, 0 failures, 0 errors, 0
> unexpected passes
>
> Please, if you change stuff in these external packages, run the tests.
> It is extremely painful to have to fix them afterwards.

Yeah!
This is why this is important that we manage external (but dev  
packages in our change process).


Stef

_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to