> One other thing... when doing the SystemWindow lookup in > ScrollPane... there > is (with Polymorph) a #window method implemented in Morph that might > simplify the changes.
Ah! Excellent! I updated the code. Morphic-Alexandre_Bergel.395 in PharoTaskForces Cheers, Alexandre > > Regards, Gary > > ----- Original Message ----- > From: "Alexandre Bergel" <[email protected]> > To: <[email protected]> > Sent: Friday, January 08, 2010 1:17 PM > Subject: Re: [Pharo-project] Notifications of windows opening/ > closing/focus > > >> Thanks for your comments. >> I renamed the announcement accordingly to your comments. I attached a >> screenshot of the new hierarchy >> >> Better? >> >> Alexandre >> >> >> > > > -------------------------------------------------------------------------------- > > > > > > On 8 Jan 2010, at 08:57, Henrik Johansen wrote: > >> On Jan 8, 2010, at 11:56 18AM, Gary Chambers wrote: >> >>> Looks ok to me. >>> >>> Regards, Gary >>> >>> ----- Original Message ----- >>> From: "Stéphane Ducasse" <[email protected]> >>> To: <[email protected]> >>> Sent: Thursday, January 07, 2010 8:27 PM >>> Subject: Re: [Pharo-project] Notifications of windows opening/ >>> closing/focus >>> >>> >>>> >>>>> Hi! >>>>> >>>>> In the PharoTaskForces SqueakSource repository I committed a new >>>>> version of Morphic (Morphic-Alexandre_Bergel.393). This version >>>>> includes the window announcement I have been working on for few >>>>> months >>>>> already. >>>>> >>>>> Here is an example of a unit test. >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> MorphicWindowNotificationTest>>testWindowCreationAndDeletion >>>>> >>>>> | t window newWindowCreated r | >>>>> t := 0. >>>>> World announcer on: MorphicCreationWindowAnnouncement do: [:ann | >>>>> t := t + 1. newWindowCreated := ann window]. >>>>> World announcer on: MorphicClosingWindowAnnouncement do: [:ann | >>>>> t := >>>>> t + 10. newWindowCreated := ann window]. >> I don't particularly like the naming. >> >> - Why including Announcement at the end? >> - Why does one contain a verb, and the other a >> - When are they fired? Closing implies to me it's not been closed >> yet, but fired somewhere after the closing has started, while >> CreationWindow I have no idea what means. >> >> MorphicWindowOpen(ed/ing) >> MorphicWindowClos(ed/ing) >> >> are both easier to read for me, shorter, and more in line with the >> naming convention for Pragma announcements already in Pharo. >> >> Cheers, >> Henry >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > > > -------------------------------------------------------------------------------- > > >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
