Hi Fernando, > File out the classes and edit and replace the underscores > assignments with :=, and they load just ok. > But Juan also modified other classes and methods referenced/used > while adopting the new editors objects. > > You can adopt it right away for Glamour, but remember that Morphic > in Cuis has a cleanup, and some methods may be not be there. > > I'm tracking them and will prepare a change set, for compatibiliy > with the Morphic in Cuis and Morphic in Pharo. For example Text in > Cuis, has some > methods that in Pharo are missing.
I will wait for your notice then. > Juan did a really great work on this refactoring! and we should > integrate it as soon as posible. I very much agree :). Cheers, Doru > Fernando > > On Jan 10, 2010, at 5:50 PM, Tudor Girba wrote: > >> It would be really great to have that in Pharo. I would adopt it in >> Glamour in a heartbeat :) >> >> Is there an easy way to load this code in Pharo? Especially given >> that >> it looks like it can live side-by-side with the current editor. >> >> Cheers, >> Doru >> >> >> On 10 Jan 2010, at 16:45, Fernando olivero wrote: >> >>> Juan re-factored the smalltalk behavior in the editors, creating the >>> following hierarchy >>> >>> Editor >>> TextEditor SimpleEditor >>> SmalltalkEditor >>> >>> >>> See the comment in Editor class in Cuis image >>> http://www.jvuletich.org/Cuis/Index.html >>> . >>> >>> New text editors. >>> TextEditor provides most of the functionality that used to be in >>> TextMorphEditor. This class is no longer a Controller! >>> >>> SmalltalkEditor is has Smalltalk code specific features. >>> >>> SimpleEditor provides basic functionality for single line text >>> editing. It does not handle fonts and styles, aligning and Smalltalk >>> utilities. It handles one single line. >>> >>> Would be nice to adopt this refactoring into Pharo, i've started to >>> port it and cleaning up the textmorph in the process. But it's still >>> a work in progress. >>> >>> Fernando >>> >>> On Jan 10, 2010, at 3:09 PM, Tudor Girba wrote: >>> >>>> Hi, >>>> >>>>> Gary and others >>>>> >>>>> I really think that we should do an audit of Morphic. In 1.1 we >>>>> are >>>>> going already faster but I'm sure that there is plenty >>>>> of space for improvements. >>>>> >>>>> I see several actions >>>>> - checking squeak toolbuilder enhancements and using it for the >>>>> tools >>>>> >>>>> - checking CUIS >>>>> - juan did an excellent job remocving a lot of unnecessary code >>>>> - juan optimize scrollbar >>>>> - juan did a new texteditor morph >>>> >>>> Indeed, a text editor that does not hardcode smalltalk specific >>>> behavior would be great :). >>>> >>>>> - removing/cleaning extra widgets Pluggable/nonpluggable plague. >>>>> - integrating better polymorph into the widgets layer. >>>>> >>>>> What do you think? >>>> >>>> >>>> Doru >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "Reasonable is what we are accustomed with." >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [email protected] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [email protected] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> -- >> www.tudorgirba.com >> >> "Be rather willing to give than demanding to get." >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- www.tudorgirba.com "To lead is not to demand things, it is to make them happen." _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
