Lukas Renggli wrote:
>
> Hi Stan,
>
>> Some are failing, as there are $' characters being passed through from
>> the
>> parser. Also, the literals check sees to be checking the node, rather
>> than
>> the node value.
>
> You are right, the code that extracted arguments and temps
> unnecessarily put the names into $' characters. This is totally wrong
> and also breaks the highlighting in the browser. Instead of changing
> the tokenizer (as you proposed) I fixed the places where the nodes
> were collected. Like this there should be no more $' characters in the
> strings that are checked.
>
> Name: Refactoring-Spelling-lr.10
> Author: lr
> Time: 12 January 2010, 12:16:16 am
> UUID: b40774a4-8371-42f4-883c-469d6fe1e020
> Ancestors: Refactoring-Spelling-lr.9
>
> - fixed the bug pointed out by Stan Shepherd that temps and arguments
> were not properly checked
> - this also fixes the issue of not highlighting typos in temps and
> arguments (which I looked into earlier today, but couldn't figure out
> the real cause)
>
>> There are some suggested changes in the same repository, that make the
>> tests
>> run green, and don't appear to affect the rest of Refactoring-Tests.
>
> The tests are really cool. I would like to add them to the main
> repository, but two are broken depending on what checker is used:
>
> RBMacSpellChecker: #testLiteralValues and #testPoolVariable
> RBInternalSpellChecker: #testLiteralValues and #testClassComments
>
> Maybe that could be fixed by always using the internal one for the
> tests, but then I don't understand why the tests break. Does my fix
> not solve the whole problem?
>
> Lukas
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
Glad you like the tests.
In my version of RBSpellChecker>>normalize, I also commented out the line:
"or: [ input peek = $' ]" "this causes false positives eg 'OK' in class
comments"
OK returns an error on k, RB b etc.
So that's what causes the two cases on a Linux box (fairly sure). I'm
guessing you have letters k i b and t in the Mac dictionary, or it
specifically doesn't check one letter words?
As for the Mac, I didn't think of that. I'd say you have 'Smalltalk' in your
Mac dictionary.
I chose that as the error Pool Dictionary, to avoid polluting the system
with a dictionary and risk it failing to clean up.
So we could temporarily add a Pool Dictionary in setUp/tearDown, which was
how I originally did it.
BTW, it looks like RBPoolVariableNameSpellingRule should be
RBPoolDictionaryNameSpellingRule, as that's what it looks at?
Cheers, ...Stan
PS just noticed that code critics browser doesn't highlight Method
protocols, even though it does find the typos. Could be related, but I don't
think so.
--
View this message in context:
http://n2.nabble.com/Spell-check-test-cases-tp4288633p4288993.html
Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
