Lukas: if you then copy these tests in RB repository let me know so that I can included in Dev image.
cheers mariano On Tue, Jan 12, 2010 at 11:57 AM, Lukas Renggli <[email protected]> wrote: > > I think you didn't pick up the other fix in RBBugFixes > > > > RBLiteralValuesSpellingRule>>initialize > > super initialize. > > matcher := RBParseTreeSearcher new. > > matcher matches: '`#literal' > > do: > > [ :node :answer | > > | nodeValue | > > nodeValue := node value. > > (nodeValue isString or: [ nodeValue isSymbol or: [ > nodeValue isCollection > > ] ]) ifTrue: > > [ answer add: nodeValue ]. > > answer ] > > Thank you. Indeed, I did not see this change. I implemented it > slightly different to ignore ByteArrays and to flatten out nested > literal array collections. > > > The tests are on 'RB' 'OK' etc, in the quotes in class comments. Leading > > capitals are stripped off. If $' is passed through, the check gets made > on > > K', and as it is 2 characters doesn't get disallowed. That's why the > tests > > need the pass through of ' taken out at the moment. If instead, where > you > > store the result: > > result add: output contents > > if you strip out trailing $' before storing, this would let you verify > don't > > and smalltalk's as well, I think. > > Then you'd need a different test from the position in the stream for size > = > > 1. > > > > I only hit this edge case because I had a class comment about namespace > > related prefixes- 'WA' 'RB' etc. > > > > So now 'OK' is not checked, under the 'strip out leading capitals' > scenario. > > At some point it might be nice to check these as well - eg WARenderCanvas > > rather than WBRenderCanvas. YAGNI, NASA, other abbreviations. > > > > Code Critics browser still doesn't show Method Protocols in bold. > > In bold? They are highlighted here. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >
_______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
