On Mon, 8 Feb 2010, Henrik Sperre Johansen wrote: > On 07.02.2010 23:11, Mariano Martinez Peck wrote: >> Thank you very much Laurent. >> >> 2010/2/7 laurent laffont <[email protected] >> <mailto:[email protected]>> >> >> Screenshot missing >> >> Laurent Laffont >> >> >> 2010/2/7 Mariano Martinez Peck <[email protected] >> <mailto:[email protected]>> >> >> Hi folks. I was just running ImageSegment tests in 11196 and >> it is broken: 3 failing tests and 5 error. Most of them seems >> related to the same thing. >> >> I have a Syntax Error. Probaly it is due to some stuff >> integrated in the latests updates to 1.1. Then problem seems >> when writing the segment to disk and then when loading... >> >> I attach an screenshot. Does someone has an idea what can be >> the problem or how to fix it ? >> >> To reproduce, just run the tests ImageSegmentTest, >> ImageSegmentTestExport and ImageSegmentTestSwap >> >> Thanks!!! >> >> Mariano >> > I believe its due to stream positioning when crossing buffer boundries in > basicChunk, I have to debug a bit further for a solution though, sorry...
It seems to be an easy one, though I didn't try the fix, just reviewed the code. So the cause of the issue is in MultiByteFileStream >> #basicChunk, which doesn't care about readLimit. When readLimit is less than "collection size", the end of the returned chunk may be the end of a previous chunk. This method has at least two other flaws (These probably won't hurt anyone in the near future, though both can be avoided): 1. if read buffering is disabled it will raise an error 2. it assumes that the encoding of the stream is ascii compatible Levente > > Cheers, > Henry > _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
