Adrian, I appreciate the reassurance, and agree that conventions are a good idea. I further agree with Lukas that a formatter is a good way to get there, but want to make the case for doing that in a way that does not force the hands of end-user (which I appear to have done).
Bill -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Adrian Lienhard Sent: Sunday, February 28, 2010 2:52 PM To: [email protected] Subject: Re: [Pharo-project] about code formatting in pharo Hi Bill, Don't worry. Nobody wants to force you to use his conventions :) The question really only concerns the code of PharoCore. I think a consistent way of code formatting really is a good idea, even if not everybody agrees with each rule. Cheers, Adrian On Feb 28, 2010, at 18:43 , Schwab,Wilhelm K wrote: > Adrian, > > Horrible is an understatement :) Your version is a big improvement. I > frequently put ending brackets on their own line with indentation to aid in > matching, but not always. > > I do not (much) care what conventions the benevolent dictators select for > Pharo, but I **do** care that it not be forced on my code that I retain for > my own use. There should be ways to compile, export and load code and > packagets w/o encountering automatic formatting. As long as that is the > case, enjoy!! > > Bill > > > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of > Adrian Lienhard > Sent: Sunday, February 28, 2010 8:11 AM > To: [email protected] > Subject: Re: [Pharo-project] about code formatting in pharo > > I've attached the coding conventions that we use at Cmsbox and netstyle.ch. > They closely follow the suggestions of Kent Beck's "Smalltalk Best Practice > Patterns". > > According to these rules I would format the following example: > > --------------- > 1 to: (mine size min: his size) do: > [ :ind | > (mine at: ind) = (his at: ind) > ifTrue: [ self instVarAt: ind put: > (anotherObject instVarAt: ind) ] ]. > --------------- > > as: > > --------------- > 1 > to: (mine size min: his size) > do: [ :index | > (mine at: index) = (his at: index) ifTrue: [ > self > instVarAt: index > put: (anotherObject instVarAt: index) ] ]. > --------------- > > Putting "[ :ind |" on a new line and using multiple tab indentation looks > horrible to me. > > Cheers, > Adrian > > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
