No idea but they all check 

        Smalltalk platformName = 'Win32' 

with strings 

        and sometimes even 
                (Smalltalk getSystemAttribute: 1001) = 'Win32'
        I prefer

                Smalltalk isWin32

But I think that we can do better and probably in the future.
Smalltalk should be a bridge to real class like platform that will contain this 
code.

        Smalltalk platform isWin32

Right now let us try to avoid this strings everywhere. 

Stef
 

On Mar 18, 2010, at 9:38 PM, Michael Rueger wrote:

> On 3/17/10 1:11 PM, Stéphane Ducasse wrote:
>> What do you think about that?
>> I think that would be good.
>> 
>> Issue 2159: We should clean all the platformName = 'Win32' and: [osVersion = 
>> 'CE']
>> 
>> This is not good to have all these strings to encode platform support.
>> We should move some code to SmalltalkImage
> 
> isn't that what the OSPlatform classes are meant to do?
> 
> Michael
> 
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to