Basically, i would remove the old cruft in SourceFileArray and all paranoia about reaching size limit, and leave only a fresh implementation (ExpandedSourceFileArray). I don't see why someone would want to revert to old behavior.
On 13 May 2010 10:56, Igor Stasenko <[email protected]> wrote: > On 13 May 2010 10:33, Stéphane Ducasse <[email protected]> wrote: >> oops >> Igor do you have more information? >> how do we do that? >> > just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk. > > As far as i can tell, everything else should work fine after that. > This is not my contribution , so i don't know all nuances, sorry. > > I just made things which allow source pointers > 32Mb to be stored in > method trailers, while others put this in use in various places :) > >> Stef >> >>> I found this message in CompiledMethod, which should be: >>> >>> CompiledMethod>>checkOKToAdd: size at: filePosition >>> "Issue several warnings if the end of the changes file is approaching >>> a fixed size limit, and finally halt with an error if the limit is >>> reached." >>> >>> ^ SourceFiles checkOKToAdd: size at: filePosition >>> >>> looks like Pharo didn't integrated this method. >>> >>> also, make sure you using a proper source file array.. >>> >>> SourceFiles class == ExpandedSourceFileArray >> >> >> >> >>> >>> On 13 May 2010 03:10, Igor Stasenko <[email protected]> wrote: >>>> 2010/5/13 Mariano Martinez Peck <[email protected]>: >>>>> Hi. I have the following error: >>>>> >>>>> 'You have reached the size limit of the changes file. >>>>> You must take action now to reduce it. >>>>> Close this error. Do not attempt to proceed.' >>>>> >>>>> I know this is a known error, but I thought that with Igor's new method >>>>> trailer this was fixed. >>>>> >>>> >>>> Seems like a leftovers of old stuff, with precautions once you >>>> reaching the size limit. >>>> >>>> Close this error. And attempt to proceed. >>>> >>>> :) >>>> >>>>> Tested in 11355 >>>>> >>>>> Thanks >>>>> >>>>> Mariano >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> [email protected] >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>> >>>> >>>> >>>> -- >>>> Best regards, >>>> Igor Stasenko AKA sig. >>>> >>> >>> >>> >>> -- >>> Best regards, >>> Igor Stasenko AKA sig. >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [email protected] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Best regards, > Igor Stasenko AKA sig. > -- Best regards, Igor Stasenko AKA sig. _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
