Marcus just did it.

Now this is a pity since sorted returns a new collection and sort in Squeak 
(does a in place sort)

In squeak too
reverse
        "This method will be the in place version sometime"
        
        self deprecated: 'Use #reversed'.
        ^self reversed

it was nice to have a coherent protocol.

Stef

On May 13, 2010, at 4:37 PM, Lukas Renggli wrote:

> Please integrate this fix:
> 
> http://code.google.com/p/pharo/issues/detail?id=2428
> 
> On 13 May 2010 14:12, Lukas Renggli <[email protected]> wrote:
>>> What ansi specifies for reversed?
>> 
>> The problem is that #reverse is deprecated in Pharo 1.1. I didn't look
>> at the implementation of #reversed. If that can be fixed then Seaside
>> 3.0 passes all tests in Pharo 1.1 (after I committed a few changes).
>> 
>> ANSI on reverse:
>> 
>> 5.7.8.26 Message:       reverse
>> 
>> Synopsis
>> 
>> Answer a collection with the elements of the receiver arranged in
>> reverse order. Definition: <sequenceReadableCollection>
>> Answer a collection conforming to the same protocols as the receiver,
>> but with its elements arranged in reverse order.
>> This operation is equivalent to:
>> 1. Create a new collection which conforms to the same protocols as the 
>> receiver;
>> 2. Traverse the elements of the receiver in the order specified by the
>> #reverseDo: message, adding each element of the receiver to the new
>> collection;
>> 3. Answer the new collection.
>> 
>> Return Values
>> <RECEIVER>
>> 
>> Errors
>> none
>> 
>> On 13 May 2010 09:23, Stéphane Ducasse <[email protected]> wrote:
>>> yes
>>> the idea was to have
>>>        sort
>>>        sorted
>>>        reverse
>>>        reversed
>>> 
>>> for inplace/copy based situation.
>>> What ansi specifies for reversed?
>>> 
>>> Stef
>>> 
>>> On May 13, 2010, at 6:47 AM, Lukas Renggli wrote:
>>> 
>>>> The recent change of renaming #revese to #reversed introduces problems
>>>> in the Seaside code-base.
>>>> 
>>>> While I agree that the renaming makes sense, #reverse is part of the
>>>> ANSI standard and supported by all other Smalltalk implementations. In
>>>> Seaside we are forced to use it.
>>>> 
>>>> Could Pharo re-add a not-deprecated delegator of #reverse in
>>>> SequenceableCollection? I have the opinion that Pharo should follow
>>>> ANSI if this is easily possible, because this is the only mean of
>>>> having some minimal kind of compatibility.
>>>> 
>>>> Lukas
>>>> 
>>>> --
>>>> Lukas Renggli
>>>> www.lukas-renggli.ch
>>>> 
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [email protected]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>> 
>>> 
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [email protected]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>> 
>> 
>> 
>> 
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>> 
> 
> 
> 
> -- 
> Lukas Renggli
> www.lukas-renggli.ch
> 
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to