I am in PharoCore 12066 and there are still references to
PluggableButtonMorphPlus, which doesn't exist anymore:


1) MorphicToolBuilder >> buttonClass
    ^ PluggableButtonMorphPlus

is it ok to change it to

buttonClass
    ^ PluggableButtonMorph

?

2) UITheme >> newButtonIn: aThemedMorph for: aModel getState: stateSel
action: actionSel arguments: args getEnabled: enabledSel getLabel: labelSel
help: helpText


    |b|
    b := PluggableButtonMorphPlus
            on: aModel
            getState: stateSel
            action: actionSel
            label: labelSel.

....

is it ok to change it to

    |b|
    b := PluggableButtonMorph
            on: aModel
            getState: stateSel
            action: actionSel
            label: labelSel.

?


3) MorphicToolBuilderTests >> expectedFailures
    "Polymorph override of PluggableButtonMorphPlus>>update: makes color not
being updated anymore in respond to sending #changed:. Was this an
intentional change and this test is obsolete?"
    ^ #(testGetButtonColor)


I don't know how this one should be. But it should be updated, at least the
class name.

Thanks

Mariano
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to