thanks for the explanation and code. On Aug 2, 2010, at 3:43 AM, Henrik Johansen wrote:
> > On Aug 1, 2010, at 10:40 53AM, Lukas Renggli wrote: > >> The changes I submitted are the ones of Eliot adapted to work in >> Pharo. I don't understand what Henrik writes, if he has something >> better he should attach the change. >> >> Lukas > > Not better, just simpler code. > > If I'm not mistaken, if primitive 38 fails in Cog, so will primitive 60. > Primitive 38 will always fail in a non-cog vm. > The failure handling code after the ec == nil check is the same in > Float>>basicAt: and Object basicAt: > > Thus, writing > Float>>basicAt: index > <primitive:38> > ^super basicAt: index > > would yield the exact same result, with the difference that you will have an > extra primtive 60 failure in Cog vm's, an ec = nil check less in non-cog > VM's, and no duplication of the fallback-handling code. > > The alternate code was attached, in issue 2581. > > Cheers, > Henry > >> >> On Sunday, August 1, 2010, Stéphane Ducasse <[email protected]> >> wrote: >>> lukas >>> >>> could you have a look at >>> http://code.google.com/p/pharo/issues/detail?id=2579 >>> because henrik mentioned that we missed something or could do it better. >>> >>> Stef >>> >>> >>> On Jul 26, 2010, at 1:32 PM, Lukas Renggli wrote: >>> >>>>>>> The image I got is based on the sources from 27.06.2010. >>>>>> >>>>>> You may be missing some image-side changes. The CogVM was open sourced on >>>>>> 20.06.2010. >>>>> >>>>> Actually, where should I get the complete image-side changes from? I have >>>>> those prepared by Lukas a while ago. >>>> >>>> Yeah, these are the complete ones from the repository adapted to Pharo. >>>> >>>> Maybe these same socket related crashes that randomly appear with >>>> Seaside images? >>>> >>>> nanosleep: Invalid argument >>>> Exited with exit code: 1 >>>> >>>> Lukas >>>> >>>> -- >>>> Lukas Renggli >>>> www.lukas-renggli.ch >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [email protected] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [email protected] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> Lukas Renggli >> www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
