Hi Dale... being really new to all this, I might state the obvious, but my impression currently is that
The purpose of isMetacelloConfig was to produce a class-side default method returning false if ob-metacello package is installed and override it when necessary in subclasses (class side) The (false in Pharo) assumption was that Class is the proper base to cover all cases. Pharo has Traits which are not Classes, and on encountering these the assumption failed. Putting isMetacelloConfig default method also to Trait sounds to me better than putting it to Object, as the intention was to have it just on the class/trait side of things. I do not know if it actually works, but maybe isMetacelloConfig default method should be defined in a Trait itself and used by Class and Trait? Ciao ...Jochen Am 03.08.2010 um 21:34 schrieb Dale Henrichs: > Mariano, > > My actual fix was to add the method to Object ... does that fix not work? > > Dale > > Mariano Martinez Peck wrote: >> On Tue, Aug 3, 2010 at 7:29 PM, Stéphane Ducasse <stephane.duca...@inria.fr >> <mailto:stephane.duca...@inria.fr>> wrote: >> we could add that to trait is this helps. >> Not necessary. It will just have the *ob-metacello category so that with >> Monticello it is packaged inside the Mteacello packages. >> just the same as Class >> isMetacelloConfig >> (I guess) >> On Aug 3, 2010, at 7:25 PM, Mariano Martinez Peck wrote: >> > You spotted a Metacallo bug. Thanks for the report. >> > >> > The problem is (I think) that in >> > >> > OBCmdMetacello >> isActive >> > ^ ((target isKindOf: OBClassNode) >> > and: [ requestor isSelected: target ]) >> > and: [ self selectedClass isMetacelloConfig ] >> > >> > >> > selectClass can be a Trait, not necessary Behavior. >> > >> > If you see, Metacello implemented >> > >> > Class >>isMetacelloConfig >> > >> > ^false >> > >> > But nothing in Trait. So...you can just add it also in Traits or... >> > >> > Maybe moving that method to Behavior helps? I am not sure how >> Traits is implemented. Can you check? >> > >> > The problem is that Gemstone doesn't have Traits...thus problably >> why the bug exists :) >> > >> > Cheers >> > >> > Mariano >> > >> > >> > >> > On Tue, Aug 3, 2010 at 6:16 PM, Jochen Riekhof <li...@riekhof.de >> <mailto:li...@riekhof.de>> wrote: >> > Hi... >> > >> > just noticed that I get a walkback after creating a Trait and >> then opening the Context-Menu on the browser's classes list pane. >> It complains >> > MessageNotUnderstood: Trait>>isMetacelloConfig >> > >> > Adding the missing method to Trait solves the issue. Probably it >> is just missing from {ob-metacello} package? >> > >> > Ciao >> > >> > ...Jochen >> > >> > >> > _______________________________________________ >> > Pharo-project mailing list >> > Pharo-project@lists.gforge.inria.fr >> <mailto:Pharo-project@lists.gforge.inria.fr> >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > >> > _______________________________________________ >> > Pharo-project mailing list >> > Pharo-project@lists.gforge.inria.fr >> <mailto:Pharo-project@lists.gforge.inria.fr> >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project@lists.gforge.inria.fr >> <mailto:Pharo-project@lists.gforge.inria.fr> >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
