I agree with Levente. The basic completion (cmd-q) is also only usable
with a SmalltalkEditor.
Cheers
Alain
Le 08/12/2010 03:58, Levente Uzonyi a écrit :
On Wed, 8 Dec 2010, Francisco Ortiz Pe?aloza wrote:
So Levente you're saying that given the following use case you musn't
add
#model to TextEditor but change TextEditor collaboration with an
instance of
SmalltalkEditor
OCompletion works well to edit code in the system browser as is, the DNU
occurs when as an example you do a class find (Cmd+f) on
SystemBrowser and
you start typing on that "Class name or fragment" window looking for
something.
Adding the accessor is fine of course, it may be useful for other
things too. I'm saying that OCompletion is intended to work in places
where code completion is necessary and those places are usually
SmalltalkEditors. There are two things to think about:
- should OCompletion be used in that panel?
- should that panel use TextEditor instead of SmalltalkEditor?
Btw using the latest version of PharoCore (12271) I can't reproduce
the error in the way you described it.
Levente
Cheers,
Francisco
On Tue, Dec 7, 2010 at 9:07 PM, Levente Uzonyi <[email protected]> wrote:
On Tue, 7 Dec 2010, [email protected] wrote:
Status: Accepted
Owner: guillermopolito
New issue 3385 by guillermopolito: TextEditor doest not understand
#model
http://code.google.com/p/pharo/issues/detail?id=3385
The accessor should be added to load last version of OCompletion in
Core
1.2
OCompletion shouldn't be used in a TextEditor. OCompletion is for
Smalltalk
code completion, while TextEditor is intended to be a text editor (ask
Juan). That's why OCompletion adds the model accessor to
SmalltalkEditor and
not to TextEditor.
Levente
