Status: Accepted
Owner: luc.fabresse
Labels: Milestone-1.2 Type-FailingTest
New issue 3398 by luc.fabresse: SystemNavigation and SourcedMethodReference
http://code.google.com/p/pharo/issues/detail?id=3398
6 tests in SystemNavigationTest and
SystemNavigationOnNewlyCreatedEnvironementTest are failing in 1.2-12272
This is because of the introduction of SourcedMethodReference.
I already speak about this problem here:
http://forum.world.st/About-SourcedMethodReference-td3035187.html
SourcedMethodReference>>= must not be based on identity (==) because it
prevents to have multiple SourcedMethodReference pointing to the same
CompiledMethod.
And we need that because each tools will use different
SourcedMethodReference.
IMHO, SourcedMethodReference are just proxies and we don't care of their
identity.
I attach a cs that make these 6 tests pass.
I replace MethodReference by SourcedMethodReference in SystemNavigationTest
and al...
And I modified the equality method of SourcedMethodReference:
SourcedMethodReference>>= anotherMethodReference
^ (super = anotherMethodReference)
and: [ (self timeStamp = self timeStamp)
and: [ self sourceCode = self sourceCode ]]
I have no idea of the impact of this change for the SourcedMethodReference
stuff point of view.
Attachments:
FixFailingSystemNavigationTests.1.cs 3.6 KB
