On Fri, 17 Dec 2010, David T. Lewis wrote:
On Fri, Dec 17, 2010 at 06:39:33PM +0100, Levente Uzonyi wrote:
On Fri, 17 Dec 2010, Javier Pim?s wrote:
OK, if I'm correct the 3449 issue is fixed and integrated now. So how do we
solve this one? Because the method lays on VMMakerTool's code, for squeak.
Maybe we can add a line to ConfigurationOfVMMaker>>#fixVMMakerForPharo like
this:
<snip>
It's a bit of a dirty hack, maybe there's a cleaner way. What do you think?
No need to do dirty hacks, just communicate your needs properly. Ask David
to update the method. Squeak (since 3.9) also implements UIManager >>
#chooseFileMatching:label:. Note that the name of this method is a bit
misleading. The first argument is a list of "file extensions", not a list
of patterns. So this should work in both Squeak and Pharo:
fileResult := UIManager default
chooseFileMatching: #('config')
label: 'Select VMMaker configuration...'.
Since fileResult is a string that contains the full path, the variable
"file" is not necessary anymore.
This is in VMMaker-dtl.211.
The #saveConfig method had a similar problem, so I changed it to
use UIManager>>request:initialAnswer:
Both methods should work on Squeak/Pharo now.
Thanks.
Levente
Thanks,
Dave
