On 12 August 2011 01:52, Damien Pollet <[email protected]> wrote:
> Again, while we're at it…
>
> The definition of PPSmalltalkGrammar>>#binary looks wrong. It would
> not parse -- (double dash) as a binary selector. Camillo and I added a
> few tests for this, and a quick fix, but the way that rule was written
> suggests it was voluntary to forbid dashes after the first character.
>
> I guess it should be scrutinized a bit more, especially since I think
> various dialects accept different lengths and characters for binary
> selectors…

I saw your change and committed some more fixes.

Up until a few years ago no Smalltalk allowed a dash in the last place
of a binary selector. I fixed this a while ago in the refactoring
browser, but didn't adapt the PPSmalltalkGrammar.

Lukas

-- 
Lukas Renggli
www.lukas-renggli.ch

Reply via email to