Veronica, i've started to adopt Ring in Gaucho. Very nice work,
excellent tests also!

A question, why does the following is true?

Collection asRingDefinition methods isEmpty = true

If you look at the following method,   they should be added here
right?, on the ring definition creation.

Class>>asRingDefinition

       | ring |
       ring := (RGFactory current createClassNamed: self name)
               category: self category;
               superclassName: self superclass name;
               traitCompositionSource: self traitCompositionString;
               addInstanceVariables: self instVarNames;
               addClassVariables: self classVarNames;
               addPoolDictionaries: self poolDictionaryNames;
               comment: self organization classComment;
               stamp: self organization commentStamp;
               definitionSource: self definition;
               withMetaclass.
       ring theMetaClass
               traitCompositionSource: self theMetaClass traitCompositionString;
               definitionSource: self theMetaClass definition;
               addInstanceVariables: self theMetaClass instVarNames.
       ^ring


I'm using the latest Pharo1.4 from Jenkins.

Fernando

Reply via email to