MultiCompositionScanner>>setFont uses
TextComposer>>characterForColumnBreak...

What I do suggest is to move #characterForColumnBreak to the scanner (or
make the scanner know its composer instead of hardcoding the reference).

But since I don't really know these classes I'm totally blind :/


On Thu, Mar 15, 2012 at 1:04 PM, Stéphane Ducasse <[email protected]
> wrote:

> >
> > TextLine seems that can be safely moved along with
> MultiCompositionScanner.
>
> good!
>
> >
> >
> > - MultiCompositionScanner>>setFont
> >
> > depends on TextComposer which is packaged as Morphic-Text Support also
> >
> > This dependency is only for this method:
> >
> > TextComposer class>>characterForColumnBreak
> >
> >     ^Character value: 12
>
> I do not get it. because Character is not in Morphic
>
>
> > But if this method is so used by the scanner, then we can move it to the
> scanner and revert the dependency :)
> >
> >
> >
> http://code.google.com/p/pharo/issues/detail?id=5478&thanks=5478&ts=1331734475
> >
> > Guille
> >
>
>
>

Reply via email to