On 6 April 2012 16:53, Guillermo Polito <[email protected]> wrote:
> BasicClassOrganizer has no users... Is it there for any purpose?
>
> What about joining them?
>
Ehh... i was also looked at those classes couple years ago and
wondered why if its really worth
having so complex implementation to save few bytes of space..
I would rewrite this stuff and leave just a Categorizer with clean
protocol and structure:
- categorizer holds categories (order could be important, but i would
just keep it unspecified , i.e,
instead
OrderedCollection ( categoryName -> {.. category items .. } )
I would use Dictionary
#categoryName -> Set(items)
this class should serve basic operations like adding /removing and queries:
- what is a categor(ies) of element (if element can be include only
into single category at once)
- what are category names
- what are elements of specific category..
Period.
And it actually can serve as a general categorizer (not just for
classes/packages).
The way how BasicClassOrganizer using inheritance is abuse..
since it extends a clean concept (Categorizer) with unrelated stuff,
like classComment and commentStamp.
Class organizer, should instead delegate, or even better, Class
should use two different fields for categories and class comment..
but not mixing everything into one pile of mess.
> Guille
--
Best regards,
Igor Stasenko.
