Done - issue 5742. On 29 April 2012 08:25, Esteban Lorenzano <[email protected]> wrote:
> Hi Francisco, > > please, open an issue in bug tracker with the fix in a changeset, and I'll > integrate it as soon as possible > (yeah... is burocratic, but the only way to keep a track of fixes ;) > > Esteban > > http://code.google.com/p/pharo/issues/detail?id=5742 > On Apr 29, 2012, at 2:15 AM, Francisco Garau wrote: > > The below line in yellow fixes the issue - yupi!! > > How do I submit this? > > BallonMorph class >> string: str for: morph corner: cornerName > "Make up and return a balloon for morph. Find the quadrant that > clips the text the least, using cornerName as a tie-breaker. tk 9/12/97" > | tm vertices | > tm := self getTextMorph: str for: morph. > *tm composeToBounds. * > vertices := self getVertices: tm bounds. > vertices := self > getBestLocation: vertices > for: morph > corner: cornerName. > ^ self new color: self balloonColor; > setVertices: vertices; > addMorph: tm; > setTarget: morph > > > On 26 April 2012 00:39, Francisco Garau <[email protected]> wrote: > >> Even making the Ballon much bigger doesn't help... >> >> SimpleBalloonMorph class >> getVertices: bounds >> ^(bounds expandBy: *50*) corners atAll: #(1 4 3 2) >> >> Haven't got time to look into CharacterScanner and word wrapping. >> >> >> >> On 25 April 2012 23:45, Francisco Garau <[email protected]>wrote: >> >>> The following code demonstrates the problem: >>> >>> EllipseMorph new >>> setBalloonText: 'hello world'; >>> openInWorld >>> >>> It's always the same behaviour regardless the text (even adding an extra >>> space at the end computes a box which is too big...) >>> >>> It happens in 1.4 and 2.0. I would like to try in previous Pharos, but >>> can't get hold of 1.3 or 1.2. Are those images available somewhere? >>> >>> I am looking in BaloonMorph >> popUpForHand: >>> >>> - Francisco >>> >>> PS: sorry for the previous message on the wrong thread >>> >>> On 25 April 2012 23:10, Gary Chambers <[email protected]> wrote: >>> >>>> More like word wrapping got broken sometime on CharacterScanner >>>> cleanups... >>>> >>>> Regards, Gary >>>> >>>> Sent from my iPad >>>> >>>> On 25 Apr 2012, at 23:02, Francisco Garau <[email protected]> >>>> wrote: >>>> >>>> > Hi - the bounding rectangle of the flyover help is not big enough and >>>> always causing the last letter to show on a second line. >>>> > >>>> > If nobody has reported it, I'll try to fix it. >>>> > >>>> > Any pointers are appreciated. >>>> > >>>> > - Francisco >>>> > <Screen shot 2012-04-25 at 22.58.07.png> >>>> >>>> >>> >> > <Screen shot 2012-04-29 at 01.12.51.png> > > >
