On Mon, May 7, 2012 at 3:26 PM, Stéphane Ducasse <[email protected]>wrote:
> Mariano > > the problem is that you need a widget to show the contents of changeset > and it contains class comment, class definition, methods…. > But somehow that widget should show those elements in different ways :). > > STef > > > > > Hi guys. I don't like the fact that FlatMessageListBrowser is being used > for more things than "messages". As an example, if you select a piece of > text, right click -> method source with it, it uses this class. However, > the resulted items are not all methods, but also class comments. What does > it mean: > > > > 1) I needed to implement #category in RGCommentDefinition (see > http://code.google.com/p/pharo/issues/detail?id=5821) > > 2) If you select a class comment, and then click the button senders, > implementors or version, it breaks (because they do not make sense for > class comments) > > 3) The class comment is displayed with shout, which is ugly and doesn't > make sense > > 4) etc... > > > > So I guess in the future we should have an abstract class say > FlatListBrowser with different concrete subclasses. The buttons, and the > code pane should be adopted to what is being show (the results). > > > > I know this would take time, but I just wanted to express my opinion. > > > > Cheers > > > > -- > > Mariano > > http://marianopeck.wordpress.com > > > > >
