Sean P. DeNigris wrote
> 
> As I've been working on NewSystemProgressMorph
> 

NewSystemProgressMorph feels ready...

The most significant change is that now, when you use methods like
String>>displayProgressFrom:to:during:, you have a real API for updating the
progress bar. Instead of sending symbols to a block*, you send messages to
aSystemProgressItemMorph. For example:
  bar value: 'newLabel'         ->      bar label:
  bar value: #increment ->      increment

* see SystemProgressMorph>>label:min:max: for the mess we had before

Issue 5969: [ENH]: Clean SystemProgressMorph and friends (Part 2)
http://code.google.com/p/pharo/issues/detail?id=5969

This version is much cleaner and seems to work well. I tested it loading a
few Metacello configurations. There is a small issue where long labels make
the morph off-center for an instant, but it seems like we're moving toward
putting it in a corner anyway
(http://forum.world.st/Progress-bar-in-the-top-left-td4631530.html), so I
won't spend time fixing it now...

Fix in inbox:
SLICE-Issue-5969-ENH-Clean-SystemProgressMorph-and-friends-Part-2-SeanDeNigris.1

* Cleanup new classes
        - categorize all uncategorized methods
        - a lot of little cleanups, refactors
        - NewSystemProgressMorph
                - remove forking
                - fix recentering when long labels are added
* Integrate new classes with the system
        - Replace SystemProgressMorph with NewSystemProgressMorph (i.e. remove
SystemProgressMorph and rename NewSystemProgressMorph to
SystemProgressMorph)
        - SystemProgressBarMorph -> ProgressBarMorph (there is nothing
"system"-specific about it. It is generally useful
        - ProgressInitiationException>>defaultMorphicAction - update to new
classes/functionality
* related changes
        - Collection>>do:displayingProgress:every:
                - return immediately for empty collections
                - if aStringOrBlock is aString, use it right away
        - Polymorph - fixed some formatting (e.g. double spaces)
Status: FixReviewNeeded

--
View this message in context: 
http://forum.world.st/Progress-bar-in-the-top-left-tp4631530p4631763.html
Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Reply via email to