On Fri, Aug 3, 2012 at 9:51 AM, Mariano Martinez Peck <[email protected] > wrote:
> > > On Fri, Aug 3, 2012 at 2:12 AM, Dale Henrichs <[email protected]> wrote: > >> Mariano, >> >> Metacello is written to run on multiple Smalltalk dialects. I cannot just >> replace SystemChangeNotifier with SystemAnnouncer without considering how >> that code will affect the other platforms the Metacello runs on ... it's >> not a simple matter. >> >> > I know. My email was to show you that after a single change we have MOST > of the tests green, don't we? So it is not that broken. That's all I wanted > to show. > I know it is not easy to change. I have the same problem in Fuel for > example and how to make it work for different Pharo versions. I was > thinking the other day and maybe I will end up rewriting each: > "SystemChangeNotifier" to "FuelPortabilityLayer notifier" (the API is the > same). And then I will have subclasses of FuelPortabilityLayer for > different Pharo version...or overrides in the (already existing) > compatibility packages, not sure...using Grease is overkilling in this case > for me. > > Well, let's think together. From what I can see (let me know if it is not like that), you use SystemChangeNotifier just to make things silent. So rather than doing, for example, SystemChangeNotifier uniqueInstance doSilently: [ super runCase ] we can do [ super runCase ] valueSilently or change #doSilently to #withoutNotifications or whatever. Then we just implement those messages differently in different Pharo versions. what do you think? > > >> >> ----- Original Message ----- >> | From: "Mariano Martinez Peck" <[email protected]> >> | To: [email protected] >> | Sent: Thursday, August 2, 2012 2:44:15 PM >> | Subject: Re: [Metacello] Re: collecting all packages of a configuration >> | >> | >> | >> | >> | On Thu, Aug 2, 2012 at 11:00 PM, Dale Henrichs < [email protected] >> | > wrote: >> | >> | >> | Issue 6295[2] was the first bug that shut me down and then when I >> | went to try loading Metacello again (with a new vm) I hit Issue >> | 6336[1] so I have yet to validate whether Issue 6295 is fixed or not >> | (the resolution comment is not confidence inspiring).... >> | >> | Sean hit Issue 6461[3] a week ago and it is still open... >> | >> | Mariano, you hit 6336 a couple of days ago (I just reopened it). >> | >> | And now you've hit another issue that smells an awful lot like the >> | other two issues ... that are still unresolved >> | >> | So, right now it seems that there are some serious Pharo-2.0 issues >> | with package loading independent of Metacello. >> | >> | As I said, I'll patiently wait until the base system stabilizes a bit >> | more before taking a chance that the load might work and that I >> | might get a chance to run my unit tests ... >> | >> | >> | >> | >> | This week, SystemChangeNotifier was removed. If you just change its >> | references to SystemAnnouncer in Metacello, I got the following >> | (using last Metacello version) >> | >> | >> | >> | 678 run, 667 passes, 0 expected failures, 0 failures, 11 errors, 0 >> | unexpected passes >> | Failures: >> | >> | >> | Errors: >> | MetacelloDevelopmentCycleTutorialTests>>#testCreateNewBaseline >> | MetacelloDevelopmentCycleTutorialTests>>#testCreateNewBaseline >> | MetacelloDevelopmentCycleTutorialTests>>#testCreateNewDevelopment >> | MetacelloDevelopmentCycleTutorialTests>>#testCreateNewDevelopment >> | MetacelloDevelopmentCycleTutorialTests>>#testReleaseDevelopment >> | MetacelloDevelopmentCycleTutorialTests>>#testReleaseDevelopment >> | MetacelloDevelopmentCycleTutorialTests>>#testValidateAndSave >> | MetacelloDevelopmentCycleTutorialTests>>#testValidateAndSave >> | MetacelloInsideToolBoxTutorialTests>>#testExamples >> | MetacelloIssue136TestCase>>#testCachedIssue136 >> | MetacelloIssue136TestCase>>#testIssue136 >> | >> | >> | >> | >> | >> | >> | BTW, does anyone know if the Metacello unit tests are run by the >> | Jenkins server against 2.0? >> | >> | Dale >> | >> | [1] http://code.google.com/p/pharo/issues/detail?id=6336 >> | [2] http://code.google.com/p/pharo/issues/detail?id=6295 >> | [3] http://code.google.com/p/pharo/issues/detail?id=6461 >> | >> | >> | ----- Original Message ----- >> | | From: "Sean P. DeNigris" < [email protected] > >> | | To: [email protected] >> | >> | >> | | Sent: Thursday, August 2, 2012 1:35:08 PM >> | | Subject: [Metacello] Re: collecting all packages of a configuration >> | | >> | | >> | | Dale Henrichs wrote >> | | > >> | | > I assume that the issue is a problem in Pharo-2.0. >> | | >> | | +1. This sounds to me like >> | | http://code.google.com/p/pharo/issues/detail?id=6461 >> | | >> | | Try loading in #20232 to confirm... >> | | >> | | Sean >> | | >> | | >> | | >> | | -- >> | | View this message in context: >> | | >> http://forum.world.st/collecting-all-packages-of-a-configuration-tp4079913p4642748.html >> | | Sent from the Metacello mailing list archive at Nabble.com. >> | | >> | >> | >> | >> | >> | -- >> | Mariano >> | http://marianopeck.wordpress.com >> | >> | >> > > > > -- > Mariano > http://marianopeck.wordpress.com > > -- Mariano http://marianopeck.wordpress.com
