Hi, there
i added a bunch of accessors to ByteArray and NBExternalAddress which
having uniform look:
nb<type>At:
nb<type>At: put:
where types are:
{U}Int<8/16/32/64>
or
Float<32/64>
the problem is that indexes in ByteArray are 1-based,
but in NBExternalAddress is 0-based.
And there's already different places in code which following these rules.
But i feel like this should be uniform (so same piece of code can be
used for either bytearrays or external addresses),
to avoid confusion and mistakes.
i just not sure which one to leave: 1-based or 0-based ?
>From one side, all collections in smalltalk is 1-based..
but from other side accessing memory at 1-based offset looks also unnatural.
What you think?
--
Best regards,
Igor Stasenko.
