On Wed, Sep 5, 2012 at 1:43 PM, Goubier Thierry <[email protected]>wrote:
> Le 05/09/2012 13:31, Mariano Martinez Peck a écrit : > >> >> >> On Wed, Sep 5, 2012 at 1:31 PM, Goubier Thierry <[email protected] >> <mailto:[email protected]**>> wrote: >> >> Le 05/09/2012 13:20, Esteban Lorenzano a écrit : >> >> Hi, >> >> Me and Mariano are trying to fix the DiffMorph in 2.0 (if you >> noticed, >> it is broken), and we noticed that the difference between 1.4 >> and 2.0 is >> that now the PluggableTextMorph inside is wrapping the text (non >> respecting the endline, but arranging them to be shown in the >> morph), >> instead showing an horizontal scroll bar to move around. >> We are lost in the obscure mist of morphic world... and we don't >> know >> how to restore that behavior. >> >> Can someone help? >> >> of course, this is important... not just because, also because I >> need to >> make integrations and I cannot because I don't know what changed >> :) >> >> >> I told you Esteban :) >> Yes, we tried both, #wrapFlag: flase and #autoFit: false. And with both >> cases we still have the problem. >> > > Ok, but look at DiffMorph>>setText and it ends up calling setTextBasic:, > which, under certain conditions, does a > > self textMorph > contents: aText > wrappedTo: self innerExtent x > > Good catch. So....shouldn't there be an if of wrapFlag: and if it is true we use #contents: aText #wrappedTo: otherwise we use #newContents: ? > Which will put back the wrapFlag to true... > > (many of the textMorph contents: method may set back the wrapFlag to true. > There is something about having a nil container in the TextMorph code to > free the wrapping). > > I would really like to have the Jejak tracer working on 2.0 to be able to > see better what's going on. > > Thierry > > > We were doing, for example: >> >> newSrcMorph >> "Answer a new src text morph." >> | pluggableTextMorph | >> pluggableTextMorph := (self newTextEditorFor: self >> getText: nil >> setText: nil >> getEnabled: nil) >> hideVScrollBarIndefinitely: true; >> borderWidth: 0; >> enabled: false; >> wrapFlag: false; >> selectionColor: self textSelectionColor; >> setText: ''; >> hShowScrollBar; >> alwaysShowHScrollBar: true. >> pluggableTextMorph textMorph autoFit: false. >> pluggableTextMorph textMorph wrapFlag: false. >> ^ pluggableTextMorph >> >> >> same problem :( >> >> I'm attaching two images of how it should be and how it is now. >> >> Thanks, >> Esteban >> >> >> There is something called wrapFlag in TextMorphForEditView inside >> all PluggableTextMorph(s). >> >> Not sure if this is the setting forcing that behavior. >> >> Thierry >> -- >> Thierry Goubier >> CEA list >> Laboratoire des Fondations des Systèmes Temps Réel Embarqués >> 91191 Gif sur Yvette Cedex >> France >> Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95 >> >> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.**com <http://marianopeck.wordpress.com> >> >> > > -- > Thierry Goubier > CEA list > Laboratoire des Fondations des Systèmes Temps Réel Embarqués > 91191 Gif sur Yvette Cedex > France > Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95 > > -- Mariano http://marianopeck.wordpress.com
