2012/9/6 Mariano Martinez Peck <[email protected]>: > > > On Thu, Sep 6, 2012 at 9:45 PM, Nicolas Cellier > <[email protected]> wrote: >> >> A bot providing simple diffs would help more eyes reviewing code... >> By now this important work is restricted to a narrow team of busy >> active developpers. >> Of course, CI may help a bit, but monkeys don't read code they just >> evaluate it. >> > > I am not sure if the changes in this slice are important. I think it just > happens that for certain reason, we have this problem of the last literal. >
I just can't tell if it would help or not, without diff I'm totally blind ;) But sure, a correct code can uncover a bug elsewhere... >> >> Nicolas >> >> 2012/9/6 Mariano Martinez Peck <[email protected]>: >> > Hi guys. So we have a case where we can reproduce the problem. See >> > http://code.google.com/p/pharo/issues/detail?id=6644 >> > >> > If you take a Pharo 20274 and load this slice: >> > SLICE-Issue-6635-Removing-class-does-not-remove-class-tag-CamilloBruni.1 >> > , >> > the #testInstanceSideMethodsWithNilKeyInLastLiteral starts to fail and >> > we >> > have lots of instance side methods with nil in the last literal (in >> > fact, >> > from the package that the slide installs). >> > I tried to debug the #basicLoad and MC friends to see if I come to the >> > real >> > problem but no luck so far. >> > If anyone wants to take a look, it would be great since I think this is >> > a >> > really important bug. >> > >> > Thanks, >> > >> > -- >> > Mariano >> > http://marianopeck.wordpress.com >> > >> > > > > -- > Mariano > http://marianopeck.wordpress.com >
