On 2012-09-09, at 15:25, Mariano Martinez Peck <[email protected]> wrote:

> On Sun, Sep 9, 2012 at 3:20 PM, Camillo Bruni <[email protected]>wrote:
> 
>> 
>> On 2012-09-09, at 15:16, Mariano Martinez Peck <[email protected]>
>> wrote:
>> 
>>> allFileNames
>>> cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ].
>>> ^ allFileNames ifNil: [
>>> allFileNames := self loadAllFileNames]
>>> 
>>> 
>>> If you put a halt in the first if, you will see it stops...
>>> because cacheFileNames is nil. In 1.4 you have:
>>> 
>>> allFileNamesOrCache
>>> ^ allFileNames ifNil: [self allFileNames]
>>> 
>>> so it kind of always cached... so maybe this is a difference that affects
>>> the results?
>> 
>> 
>> humm you might be right |(. so metacello should explicitely tell to cache
>> stuff in 2.0 then
>> 
>> 
>> 
> 
> I would do
> 
> MCFileBasedRepository >> initialize
> cacheFileNames := true
> 
> or something like test. But first, we should be sure this was really one of
> the causes of the slowdown

you'll break the whole download optimizations if you enable these caches there,
since it will never find the newly downloaded files again :P

I think there is a method, something like cacheAllFileNamesDuring: or so...


Reply via email to